Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runInBinDir and {{BIN_DIR}} are inconsistent #106

Open
Vampire opened this issue Oct 28, 2021 · 3 comments
Open

runInBinDir and {{BIN_DIR}} are inconsistent #106

Vampire opened this issue Oct 28, 2021 · 3 comments
Labels
bug Something isn't working

Comments

@Vampire
Copy link

Vampire commented Oct 28, 2021

If you set runInBinDir to true, the start script does not actually cd into the bin dir, but to the place where the startscript is stored (which is good).
But the {{BIN_DIR}} variable is replaced by $APP_HOME/bin or %APP_HOME%\\bin.

This is a bit inconsistent and actually the naming of runInBinDir is slightly off.

I don't know how to best solve this, as changing either would be a breaking change.
Maybe it would be a good idea to deprecate runInBinDir and replace it by runInStartscriptDir or some better name or have a more flexible option that allows to configure where exactly the process is started.

@Vampire
Copy link
Author

Vampire commented Jan 8, 2022

It's actually even worse and more inconsistent.
The Windows start scripts run it within the start script containing directory.
The Linux start script runs it within the BIN_DIR.
O_O

@satsen
Copy link

satsen commented Jan 9, 2022

@Vampire This plugin seems to have many issues and flaws and the maintainer seems to have gone quite inactive.. I don't think any problems will be fixed

@siordache
Copy link
Member

@Vampire This plugin seems to have many issues and flaws and the maintainer seems to have gone quite inactive.. I don't think any problems will be fixed

Unfortunately, this is true. I no longer have time to properly maintain this plugin.
Is anyone interested in becoming the new maintainer of this project? Just drop a line here or send me an email.

@hakanai hakanai added the bug Something isn't working label Jan 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants