Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: terraformer restarts when it can't find the required assets in Dynamo and MINIO #1326

Closed
JKBGIT1 opened this issue Apr 4, 2024 · 1 comment · Fixed by #1398
Closed

Chore: terraformer restarts when it can't find the required assets in Dynamo and MINIO #1326

JKBGIT1 opened this issue Apr 4, 2024 · 1 comment · Fixed by #1398
Assignees
@Despire
Labels
chore A chore is updating dependencies, etc; no significant code changes groomed Task that everybody agrees to pass the gatekeeper

Comments

@JKBGIT1
Copy link
Contributor

JKBGIT1 commented Apr 4, 2024

Current Behaviour

If the terraformer can't find the required assets in Dynamo or MINIO in its readiness probe it restarts.

Expected Behaviour

I would say it is similar to this one. Should the restart of the terraformer fix the missing assets in the Dynamo or MINIO?
@JKBGIT1 JKBGIT1 added the chore A chore is updating dependencies, etc; no significant code changes label Apr 4, 2024
@JKBGIT1 JKBGIT1 mentioned this issue Apr 4, 2024
Closed
@miroslavkohutik miroslavkohutik added the groomed Task that everybody agrees to pass the gatekeeper label Apr 12, 2024
@JKBGIT1
Copy link
Contributor Author

JKBGIT1 commented Apr 12, 2024

AFAIK the restart of the terraformer should prevent the user from running the workflow. Instead of restarting the terraformer pod, I propose to just keep it not ready and remove the restart.

@Despire Despire self-assigned this May 21, 2024
@Despire Despire mentioned this issue May 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Despire Despire

Labels
chore A chore is updating dependencies, etc; no significant code changes groomed Task that everybody agrees to pass the gatekeeper
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

prevent terraformer to restart on unhealthy berops/claudie
3 participants
@Despire @JKBGIT1 @miroslavkohutik