Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gender pronouns #45

Open
jachwe opened this issue May 31, 2022 · 3 comments
Open

Gender pronouns #45

jachwe opened this issue May 31, 2022 · 3 comments

Comments

@jachwe
Copy link

jachwe commented May 31, 2022

Hi. First, thank you for this great project. It helped me already a lot.
I now, for the first time, came across an issue:
When people add gender pronouns (e.g. (he/him)) to their names, the parsing fails all together.

Example:

2.7.4 :003 > Namae.parse("Max Power (he/him, er/ihm)")
 => []
2.7.4 :004 > Namae.parse("Max Power (er/ihm)")
 => []
2.7.4 :005 > Namae.parse("Max Power")
 =>
[#<struct Namae::Name
  family="Power",
  given="Max",
  suffix=nil,
  particle=nil,
  dropping_particle=nil,
  nick=nil,
  appellation=nil,
  title=nil>]

I read about adding custom suffices, but then i though that this might become it's own part.
Currently i am trying to build that in and do a PR, but it goes slowely.

So very open for hints or other opinions.

@inukshuk
Copy link
Member

Good point! Yes, I think pronouns should be their own category, because they could be given in addition to a suffix. They'd either have to be detected using syntax or by using a pattern featuring the actual pronouns; which I guess would be OK because the patterns can be adjusted at runtime so it's no big deal to add support for more languages if yours isn't covered yet.

@jachwe
Copy link
Author

jachwe commented Jun 1, 2022

Here is a PR for this.
#46

@inukshuk
Copy link
Member

inukshuk commented Jun 1, 2022

Awesome, thanks! I'll take a look at it as soon as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants