Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESQ suffix breaks name parsing #44

Open
kingIZZZY opened this issue Aug 2, 2021 · 2 comments
Open

ESQ suffix breaks name parsing #44

kingIZZZY opened this issue Aug 2, 2021 · 2 comments

Comments

@kingIZZZY
Copy link

> Namae.parse('BRYANT H DUNIVAN JR, ESQ')
=> []
> Namae.parse('JAMES W GOVIN, ESQ')
=> [#<Name family="JAMES W GOVIN" given="ESQ">]
@inukshuk
Copy link
Member

inukshuk commented Aug 2, 2021

Thanks!

One thing you could do right away is adjust the title lexer patterns at Namae::Parser.instance.options to your needs.

@kingIZZZY
Copy link
Author

Thanks! Adding it to suffix seems to have helped in this case. I hope that doesn't break any other name parsing... is ESQ supposed to be considered a title or a suffix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants