Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a "tick box" feature for pipsolar option #396

Open
ouinouin opened this issue Mar 26, 2024 · 2 comments
Open

Adding a "tick box" feature for pipsolar option #396

ouinouin opened this issue Mar 26, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@ouinouin
Copy link

Hi , the macro is :
#define USE_PIPSOLAR

see : arendst/Tasmota@3125181
I guess this option will gain traction amongst diyers having solar inverters. I m actually testing #define USE_PIPSOLAR with tasmocompiler and an ESP32-S3 to see if it compiles and its a success , i got no unmet dependencies or strange thing during compilation.

@benzino77 benzino77 added the enhancement New feature or request label Mar 26, 2024
@benzino77
Copy link
Owner

Hi,
Thanks for pointing that out. I will leave this issue open to see if there are more people interesting in that feature to be available on the features list (I don't want to overload GUI with too many options).

Based on the information that there is only one define needed, one could just put it in the "Custom parameters" field (which I think is the way you tested it).

@ouinouin
Copy link
Author

good point, its a nice way to see if there is interrest, and maybe you re right too much tick box would maybe kill the tick box :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants