Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First impressions #11

Open
kaihendry opened this issue Jul 15, 2021 · 4 comments
Open

First impressions #11

kaihendry opened this issue Jul 15, 2021 · 4 comments

Comments

@kaihendry
Copy link

I removed about.md but still it's on the page. I don't understand why. Removing the "about" line from ./themes/simple-dev-blog/theme.toml doesn't make a difference.

I replaced the profile picture curl -o profile.jpg https://upload.wikimedia.org/wikipedia/commons/c/cf/Clothing_worn_by_most_Pashtun_males.jpg and my head is cut off. haha

image

I altered the title of content/_index.md and it doesn't appear in the title of the index.html ... I'm a bit puzzled how to set the title now.

image

Otherwise, I like the aesthetic. Keep up the good work!

@bennetthardwick
Copy link
Owner

Hi, thanks for the feedback!

I don't understand why. Removing the "about" line from ./themes/simple-dev-blog/theme.toml doesn't make a difference.

You should be able to set the "nav" variable in your config.toml file to get rid of the about link:

[extra]
nav = [
{ name = "About", path = "/about/" },
{ name = "Blog", path = "/blog/" }
]

I replaced the profile picture and my head is cut off. haha

That's a very long photo! At the moment all the dimensions of the photo are hard-coded - so it might be worth cropping your photo. It's probably possible to make it responsive with CSS if you're keen to give that a go.

I altered the title of content/_index.md and it doesn't appear in the title of the index.html ... I'm a bit puzzled how to set the title now.

I'm not sure what's going on there. As long as you're setting the title variable in the frontmatter it should just work.

@kaihendry
Copy link
Author

Hey thanks for the reply! Do find it a little odd to define the nav in config.toml, though your suggested change works: https://github.com/kaihendry/enemies-of-carlotta-zola/blob/main/config.toml#L21

Not sure what responsive means RE CSS. Not using width/height? Some how focusing on the top part of the photo?

I deployed the site upon a staging https://travel.hendry.workers.dev/ via https://github.com/kaihendry/enemies-of-carlotta-zola/blob/main/.github/workflows/ci.yml and you can see that

  1. title is missing... still don't know why
  2. how come all the URLs are full (non-relative) URLs?

@kaihendry
Copy link
Author

btw my wife complains about the spacing on safari mobile haha https://s.natalian.org/2021-07-20/spacing.webp

@kaihendry
Copy link
Author

Would be nice if taxonomies were optional.

Reason: Failed to render 'blog-post.html'
Reason: Variable `page.taxonomies.tags` not found in context while rendering 'blog-post.html'

Trying to figure out how to keep the date in the URL. E.g. instead of https://travel.dabase.com/blog/where-now/ I want https://travel.dabase.com/blog/2005/where-now/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants