Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BAM only supports PDU1 PS as 255 #1

Open
martyfoulks opened this issue Jan 28, 2019 · 2 comments
Open

BAM only supports PDU1 PS as 255 #1

martyfoulks opened this issue Jan 28, 2019 · 2 comments

Comments

@martyfoulks
Copy link

My understanding of SAE J1939-21 is that BAM is not limited to PDU1 with DA as 255.

Changed :

def send_pgn(self, data_page, pdu_format, pdu_specific, priority, src_address, data):

to:

def send_pgn(self, data_page, pdu_format, pdu_specific, priority, src_address, data, *destination_address):

then only check to see if destination_address is not vs pdu_specific as 255

This change of course breaks all old implementations. A new method would be the most desirable.

@mr337
Copy link

mr337 commented Jul 8, 2020

I too ran into this.

@argandas
Copy link

Seems like you already have this solved, may I suggest to create a Pull Request for this fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants