Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github usernames are case insensitive #362

Open
lizthegrey opened this issue Oct 20, 2022 · 2 comments
Open

github usernames are case insensitive #362

lizthegrey opened this issue Oct 20, 2022 · 2 comments

Comments

@lizthegrey
Copy link
Contributor

https://github.com/benadida/helios-server/blob/master/helios_auth/auth_systems/github.py#L60-L66

it's fine to preserve the info exactly as pulled from GH but for comparison with voter rolls etc it should be okay for there to be discrepancies with the voter roll as uploaded as long as they differ only in case.

@dyladan
Copy link

dyladan commented Oct 23, 2023

I was just bit by this as well

@dyladan
Copy link

dyladan commented Oct 23, 2023

Maybe explaining the use case would help here:

I am administering the election for the OpenTelemetry Governance Committee. We generate the list of eligible voters by querying the CNCF devstats, which return github usernames normalized to lowercase. In our list of several hundred voters, i have no way of knowing which are supposed to have capital letters without querying the github API. Because GitHub does not allow multiple users to exist with usernames differing only in case, it should be safe to recognize when user ABC logs in, that they are the user abc in the voter roll.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants