Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring codebase to fix pylint issues. #32

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from
Draft

Refactoring codebase to fix pylint issues. #32

wants to merge 3 commits into from

Conversation

ben-ryder
Copy link
Owner

@ben-ryder ben-ryder commented Sep 20, 2021 •
edited

  • Adding docstrings everywhere
  • Removing unused and commented code
    • pygame_gui.Cursor
    • TILE_DATA constant
    • Commented out methods on the wood/metal/stone system that was never implemented
  • Various other small cleanups as directed by pylint

TODO

  • remove global pylint ignores in favour of adding localised ignore comments

@ben-ryder ben-ryder added the improvement Improve an existing feature label Sep 20, 2021
@ben-ryder ben-ryder self-assigned this Sep 20, 2021
@ben-ryder ben-ryder linked an issue Sep 23, 2021 that may be closed by this pull request
Look into adding pylint for pull requests and retroactively fix codebase issues #29
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ben-ryder ben-ryder

Labels
improvement Improve an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Look into adding pylint for pull requests and retroactively fix codebase issues
1 participant
@ben-ryder