Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Logging for ActiveSupport::Logger #253

Open
ashtonthomas opened this issue Feb 15, 2016 · 1 comment
Open

Drop Logging for ActiveSupport::Logger #253

ashtonthomas opened this issue Feb 15, 2016 · 1 comment
Assignees

Comments

@ashtonthomas
Copy link
Contributor

Napa currently uses the logging gem which implements its own logger class. ActiveSupport provides a nice extension to Ruby's standard logger

We are already leveraging ActiveSupport so this would eliminate some overhead and get us back closer to standard libraries.

Another benefit is the ActiveSupport::TaggedLogging which makes it really easy to tag logs with whatever we want. This proves to be difficult with the logging gem (I tried this weekend but had some trouble - seems like you can modify the :pattern but custom tags may be trickier)

Thoughts?

cc: @bellycard/platform @danielmackey @mbueti

@heymackey
Copy link
Contributor

Sounds like a good optimization, dropping a dependency and getting some benefits 👍

@ashtonthomas ashtonthomas self-assigned this Feb 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants