Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull in Napa Paginate & Rabbit Publisher? #158

Open
shaqq opened this issue Oct 26, 2014 · 5 comments
Open

Pull in Napa Paginate & Rabbit Publisher? #158

shaqq opened this issue Oct 26, 2014 · 5 comments

Comments

@shaqq
Copy link
Contributor

shaqq commented Oct 26, 2014

@darbyfrey

It seems like these gems solve some common problems, and they don't necessarily force you do anything if they're installed.

@jdoconnor
Copy link
Contributor

I recommend keeping these separate, as they can solve problems outside of
Napa, and Napa works fine without them.
On Oct 26, 2014 4:53 PM, "Shaker Islam" notifications@github.com wrote:

@darbyfrey https://github.com/darbyfrey

It seems like these gems solve some common problems, and they don't
necessarily force you do anything if they're installed.


Reply to this email directly or view it on GitHub
#158.

@shaqq
Copy link
Contributor Author

shaqq commented Oct 27, 2014

could we include them in the Gemfile when we scaffold services then?

@jdoconnor
Copy link
Contributor

That makes sense to me.
On Oct 26, 2014 5:54 PM, "Shaker Islam" notifications@github.com wrote:

could we include them in the Gemfile when we scaffold services then?


Reply to this email directly or view it on GitHub
#158 (comment).

@brandonweiss
Copy link
Contributor

I could see adding NapaPagination to the scaffolded Gemfile, although NapaRabbitPublisher seems rather niche, don't you think? I think the average Napa user might paginate an endpoint, but it's going to be a really small percentage that are going to be running RabbitMQ.

@shaqq
Copy link
Contributor Author

shaqq commented Feb 16, 2015

@brandonweiss yeah i'd agree, pagination makes more sense

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants