Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TimeFrame ALL #51

Open
LucBerge opened this issue Jul 31, 2022 · 1 comment
Open

Add TimeFrame ALL #51

LucBerge opened this issue Jul 31, 2022 · 1 comment

Comments

@LucBerge
Copy link

LucBerge commented Jul 31, 2022

In the chart section, it is possible to select 1D, 1W, 1M, 6M, 1Y and 2Y. My portfolios are more than 2 years old. I would like to be able to see the evolution of my portfolios since the beginning.

We can add a "ALL" button next to the "2Y" button.

@LucBerge
Copy link
Author

LucBerge commented Jul 31, 2022

In the appConstants.js file, add a TF_ALL value.

In the price priceDataService.js file, add a TF_ALL value with the limit value set to -1 or Infinite.

(By the way, this is not normal to have timeframe constants defined twice. Why don't you merge rhem and use only one ?)

In the Chart/index.js file, add something more to handle the -1 or Infinite value.

@LucBerge LucBerge changed the title Timeline ALL Add TimeFrame ALL Jul 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant