Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve code readbility and maintance with String Templates #306

Open
mikepapadim opened this issue Jan 11, 2024 · 5 comments
Open

Improve code readbility and maintance with String Templates #306

mikepapadim opened this issue Jan 11, 2024 · 5 comments
Labels

Comments

@mikepapadim
Copy link
Member

mikepapadim commented Jan 11, 2024

Is your feature request related to a problem? Please describe.
The feature is related to code cleanup and readability. The codebase heavily uses String concatenation for error and debug logging.

Describe the solution you'd like
We can improve code readability and maintenance by replacing String manipulation with String Templates from JDK21.

Describe alternatives you've considered

Additional context

  1. https://openjdk.org/jeps/430
@mikepapadim mikepapadim self-assigned this Jan 11, 2024
@mikepapadim mikepapadim added the good first issue Good for newcomers label Jan 11, 2024
@mikepapadim mikepapadim removed their assignment Jan 11, 2024
@jjfumero
Copy link
Member

Please, follow the template for feature request

@genzarchitect
Copy link

I would love to work on this. Can you assign it to me

@jjfumero
Copy link
Member

Hi @genzarchitect , that's excellent. I suggest @mikepapadim adding a more precise description of the scope of this task.
Feel free also to ask questions.

@mikepapadim
Copy link
Member Author

I added an example PR (#312) of what is expected in the scope of this task.

I suggest going over one package at time (e.g., tornado-drivers, tornado-runtime etc), adopting String Templates were possible and opening a PR.

@genzarchitect
Copy link

@mikepapadim I understood string template changes part but Could you tell me how to start/run this repo so that after making changes i can check .
Kindly let me know what are these and how to this because it was mentioned in PR(#312 )

Backend/s tested
Mark the backends affected by this PR.

OpenCL
PTX
SPIRV
OS tested
Mark the OS where this PR is tested.

Linux
OSx
Windows
How to test the new patch?
make
make tests

jjfumero added a commit that referenced this issue Jan 22, 2024
…askgraph

[#306] Impove code readibility in `TornadoTaskGraph` by adapting String Templates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

No branches or pull requests

3 participants