Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The result of "Format document" is weird of certain HTML content. #1223

Closed
aeschli opened this issue Aug 3, 2017 · 3 comments
Closed

The result of "Format document" is weird of certain HTML content. #1223

aeschli opened this issue Aug 3, 2017 · 3 comments
Labels
language: html type: bug
Milestone
v1.8.0

Comments

@aeschli
Copy link

aeschli commented Aug 3, 2017 •
edited

From @slayerxj on July 28, 2017 7:28
Originally reported against VSCode (which uses jsbeautifier as formatter for HTML): microsoft/vscode#31628

Steps to Reproduce:

<!DOCTYPE html>
<html>

<head></head>

<body>
    <div>
        <div>
            <p>Reconstruct the schematic editor the EDA system <a href="http://www.jedat.co.jp/eng/products.html"><i>AlphaSX</i></a> series</p>
        </div>
    </div>
</body>

</html>
  • set 'Wrap lines near 120 characters'
  • format
  • the result is
...<p>EDA system <a href="http://www.jedat.co.jp"><i>Alpha-SX</i></a>                series</p>

Notice the unnecessary spaces added before 'series'
@aeschli aeschli mentioned this issue Aug 3, 2017
Closed
@bitwiseman
Copy link
Member

@aeschli -
Excellent bug report.
With the repro steps you provided, I can reproduce the issue.

I see your original comment said you have "editor.wordWrap": "off". But then your repro steps talk mention setting wrap to 120. To have wordWrap turned off you'd set the wrap value to 0. Then this problem does not occur.

@aeschli
Copy link
Author

aeschli commented Aug 4, 2017

@bitwiseman Sorry for the confusion. Ignore the "editor.wordWrap": "off" comment. That's a VSCode setting and is not related to html formatting. I'll update the description...

@aeschli aeschli mentioned this issue Aug 16, 2017
Closed
@aeschli aeschli mentioned this issue Sep 11, 2017
Closed
@ReubenAllott
Copy link

ReubenAllott commented Oct 1, 2017 •
edited

I am seeing the same thing in VSCode 1.16.1, particularly after inline a and code tags.

I am using "&nbsp;" instead of spaces to prevent the unwanted white space appearing (the unwanted white space can cause problems in output).

@azurvii azurvii mentioned this issue Jan 12, 2018
Closed
@aeschli aeschli mentioned this issue Jan 15, 2018
Closed
bitwiseman added a commit to bitwiseman/js-beautify that referenced this issue Jun 30, 2018
@bitwiseman
Another line wrap test
8df34de 
Fixed beautifier#1223
@bitwiseman bitwiseman mentioned this issue Jun 30, 2018
Merged
@bitwiseman bitwiseman added this to the v1.7.6 milestone Jun 30, 2018
@bitwiseman bitwiseman modified the milestones: v1.8.0-rc2, 1.8.0 Aug 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
language: html type: bug
Projects
None yet
Milestone
v1.8.0
Development

No branches or pull requests
3 participants
@bitwiseman @aeschli @ReubenAllott