Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unnecessary optional type on addressMinusSuffix for Address4 #144

Closed
wants to merge 1 commit into from

Conversation

napei
Copy link

@napei napei commented Aug 1, 2021

Fixes #143

@codecov
Copy link

codecov bot commented Aug 1, 2021

Codecov Report

Merging #144 (4853bc2) into master (b1df15f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #144   +/-   ##
=======================================
  Coverage   98.08%   98.08%           
=======================================
  Files           9        9           
  Lines         575      575           
  Branches       84       84           
=======================================
  Hits          564      564           
  Misses          3        3           
  Partials        8        8           
Impacted Files Coverage Δ
lib/ipv4.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1df15f...4853bc2. Read the comment docs.

@napei napei changed the title fix: remove unnecessary optional type on addressminusSuffix for Address4 fix: remove unnecessary optional type on addressMinusSuffix for Address4 Aug 1, 2021
@napei
Copy link
Author

napei commented Nov 5, 2021

@beaugunderson ping, been a while 😅

@napei napei closed this by deleting the head repository Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Address4 addressMinusSuffix nilable query
1 participant