Address4 addressMinusSuffix nilable query

[napei]

Just querying addressMinusSuffix for Address4 and why it's nilable? From what I can see, its definitely assigned in the constructor:

ip-address/lib/ipv4.ts

Line 41 in b1df15f

this.addressMinusSuffix = address;

Perhaps I missed something though.

I'm assuming perhaps the constructor should actually complain before it parses the address if it's undefined, because if the provided address is undefined then there's no point continuing?

I'm running into a coverage issue in my library, as theoretically it won't ever be null which means I need to wrap the code in a check, either ?. or if (!a.addressMinusSuffix) which will never be exeuted, which means my coverage isn't 100%, which annoys me 😂

[beaugunderson]

great catch, happy to merge that change :)

…

On Sat, Jul 31 2021 at 22:40, Nathaniel Peiffer ***@***.***> wrote: Just querying addressMinusSuffix for Address4 and why it's nilable? From what I can see, its definitely assigned in the constructor ( https://github.com/beaugunderson/ip-address/blob/b1df15f99355bd4132b579a0db69238b563e9c39/lib/ipv4.ts#L41). Perhaps I missed something. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#143>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAPCXZUKQPNRVEIKN2DO2TT2TM5XANCNFSM5BKYNOAQ> .

[napei]

great catch, happy to merge that change :)

Do we want to throw earlier in the constructor instead? Or just leave the throw in parse()?