Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMPROVEMENT] Polls and Raffles are Inefficient #585

Open
2 of 4 tasks
beanbeanjuice opened this issue Jul 14, 2023 · 1 comment
Open
2 of 4 tasks

[IMPROVEMENT] Polls and Raffles are Inefficient #585

beanbeanjuice opened this issue Jul 14, 2023 · 1 comment
Assignees
@beanbeanjuice
Labels
critical When this is critical, it is needed for the release. improvement Something to improve the current code.

Comments

@beanbeanjuice
Copy link
Owner

beanbeanjuice commented Jul 14, 2023 •
edited

Improvement Description

  • Consolidate Polls and Raffles so they inherit from the same abstract class.
  • Make it so each of those abstract class objects have their own individual timer instead of one central timer constantly checking for completion.

Additional Context

This should remove over 200 lines of code.

Checklist

  • I have checked for similar issues.
  • This is an improvement request, not a feature request, bug report, or security vulnerability report.
@beanbeanjuice beanbeanjuice added improvement Something to improve the current code. critical When this is critical, it is needed for the release. labels Jul 14, 2023
@beanbeanjuice beanbeanjuice self-assigned this Jul 14, 2023
@beanbeanjuice
Copy link
Owner Author

#579

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@beanbeanjuice beanbeanjuice

Labels
critical When this is critical, it is needed for the release. improvement Something to improve the current code.
Projects
cafeBot v3
Status: To-Do
Milestone
No milestone
Development

No branches or pull requests
1 participant
@beanbeanjuice