Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved Templates #603

Merged
merged 2 commits into from Oct 30, 2023
Merged

Improved Templates #603

merged 2 commits into from Oct 30, 2023

Conversation

beanbeanjuice
Copy link
Owner

@beanbeanjuice beanbeanjuice commented Oct 30, 2023

Description

Improved the default templates.

Fixes #584

Type of Change

  • Bug Fix (Small Non-Code Breaking Issue)
  • Bug Fix (Critical Code Breaking Issue)
  • Feature (Something New Added to the Code)
  • Improvement (Improving An Existing Section of Code)
  • Documentation Update
  • Security Vulnerability

Changes

  • Internal Code
  • Documentation
  • Other: _____

Test Configuration:

  • Hardware:
    • CPU: AMD Ryzen 7 3800x @ 4.4 Ghz
    • GPU: Nvidia RTX 3080
    • RAM: 32 GB DDR4 @ 3600 Mhz
  • JDK: Java Oracle OpenJDK 16

Checklist:

  • This pull request has been linked to the appropriate issue on GitHub. (Use the development section on the right.)
  • The code follows the style guidelines.
  • A self-review of the code was performed on GitHub.
  • Appropriate comments and javadocs were added in your code.
  • Appropriate changes have been made to the documentation.
  • Appropriate changes have been made to the README.md file.
  • No warnings are produced when the code is run.
  • Appropriate tests exist for this pull request.
  • New and existing Maven CI tests have passed.
  • The pull request is properly merging into the correct branch.
  • All existing local code has been pushed to the GitHub repository.
  • Changes have been documented in the current draft cafeBot Releases update.

@beanbeanjuice beanbeanjuice added documentation Improvements or additions to documentation small Something small that can be added/fixed easily. improvement Something to improve the current code. labels Oct 30, 2023
@beanbeanjuice beanbeanjuice self-assigned this Oct 30, 2023
Copy link
Owner Author

@beanbeanjuice beanbeanjuice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good.

@beanbeanjuice beanbeanjuice linked an issue Oct 30, 2023 that may be closed by this pull request
2 tasks
@beanbeanjuice beanbeanjuice merged commit 58ca139 into integration Oct 30, 2023
4 checks passed
@beanbeanjuice beanbeanjuice deleted the 584-improve-templates branch October 30, 2023 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation improvement Something to improve the current code. small Something small that can be added/fixed easily.
Projects
Status: Finished
Development

Successfully merging this pull request may close these issues.

[IMPROVEMENT] Improve Templates
1 participant