Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completion not working in recent Jupyter Lab and Jupyter Notebook #112

Open
rcmlz opened this issue Feb 9, 2024 · 4 comments
Open

Completion not working in recent Jupyter Lab and Jupyter Notebook #112

rcmlz opened this issue Feb 9, 2024 · 4 comments

Comments

@rcmlz
Copy link
Contributor

rcmlz commented Feb 9, 2024

I am using recent JupyterLab/Notebook and can not get the completion get to work. One of the test cases is failing

($pos,$end,$completions) = $r.completions('if "hello world".WHA');
is-deeply $completions, $("WHAT", ), 'WHAT method';

but appart from that there are no errors I can identify. The Binder demo also has no working TAB completion.

@rcmlz rcmlz changed the title Completion not working in recent JupyterLab Completion not working in recent Jupyter Lab and Jupyter Notebook Feb 9, 2024
@bduggan
Copy link
Owner

bduggan commented Feb 10, 2024

Interesting. For the bug, perhaps this will address it: 54163f4 since there appears to be duplicate WHATs in the output. I can confirm that Tab completion is not working in Binder, though the kernel does seem to be sending the responses, yet they are being ignored. Completion does work on a local notebook. cc @sumanstats for any thoughts

@rcmlz
Copy link
Contributor Author

rcmlz commented Feb 11, 2024

applying 54163f4 did not solve the problem in JupyterLab.

I started it with jupyter lab --debug but do not see any erros when typing TAB on any object.

@bduggan
Copy link
Owner

bduggan commented Feb 11, 2024

Oh, I see it is not just binder, but JupyterLab. Yes, I am able to reproduce this. There seems to have been some sort of backwards-incompatible change to the protocol; I don't see any documentation about this here so it may take some investigation to see what has changed.

@bduggan
Copy link
Owner

bduggan commented Feb 11, 2024

Interestingly, this seems specific to JupyterLab -- completions work fine in a regular notebook or a terminal console (and the kernel is sending the same response in all those cases).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants