fix(deps): depend on release-please ^5.2.1 to support merge commits #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Versions before 5.2.1 couldn't correctly handle merge commits and releases were not created even if an user-facing change was merged.
|
@mateuszpodraza thanks for the contribution, it's awesome to have other folks contributing. Yes, all that should be necessary is running |
This was referenced Aug 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was pleasantly surprised when I've discovered that as of few hours ago, merge commits are now supported in release-please - big thanks @bcoe!
All I did here was I've ran
npm updatefollowed bynpm build- I hope that's what I was supposed to do but if not, I'm happy to do it some other way.I marked that as a fix, but I'm not sure whether incorporating upstream fixes should itself be a fix.