Scoped commits

[johan-lejdung]

Hi,

We were trying to use this Action but we normally scope our commits, so the messages look like this:

• fix(xxx): did something
• chore(xxx): did something

Rather than:

• fix: did something
• chore: did something

We noticed that this action didn't properly tag PR's that were using the scoped message style. Any plans to support it or are we using it incorrectly?

[bcoe]

Hello @johan-lejdung, would love to have you use the action 😄

Could you provide an example of this not working with scoped commits? I've tested with scoped commits, I'm wondering if something else might be biting you.

bcoe/test-generated-release-notes#10

[johan-lejdung]

Hi,

Maybe we've misunderstood the action. We thought it tagged a PR based on the commit messages, I didn't realise that the PR title also had to follow Conventional Commits.

If there any way to get it to work on Commits rather than PR?

[bcoe]

@johan-lejdung we could certainly make it work based on commits too, my only question would be how the behavior should work with multiple commits?

[johan-lejdung]

I've thought about that as well. I think for our use case the highest level commit would be responsible for tagging the PR.

Eg:
feat: xxx
fix: xxx
=>
Feature

chore: xxx
fix: breaking xxx
=>
Breaking fix

Ect... 🤓

Does that make sense?

[bcoe]

@johan-lejdung seems like a reasonable approach to me.

I would happily take a patch for this, if you're interested. Perhaps we could fallback to the commits if and only if the title isn't a conventional commit?

[johan-lejdung]

Much appreciated!

That sounds like an excellent idea 🙂

[johan-lejdung]

Will you update this thread once it's released? 🙏

[vincentchalamon]

I can confirm chore(xxx): did something works like a charm :-)