Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjusting widget text for non-English language sites #95

Open
NicoledeGreef opened this issue Jan 12, 2021 · 4 comments
Open

adjusting widget text for non-English language sites #95

NicoledeGreef opened this issue Jan 12, 2021 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@NicoledeGreef
Copy link
Contributor

NicoledeGreef commented Jan 12, 2021

We are building 2 French language sites that, for the most part, have French text throughout. There are some exceptions noted by the business area that it's believed are part of the core SMK (cannot be controlled by map configuration).

@NicoledeGreef NicoledeGreef reopened this Jan 12, 2021
FY2021 SMK Enhancements to support Product Launch and beyond automation moved this from For Discussion to In progress Jan 12, 2021
@NicoledeGreef NicoledeGreef changed the title adjust text for French sites adjusting widget text for French sites Jan 12, 2021
@NicoledeGreef NicoledeGreef added enhancement New feature or request post-launch labels Jan 15, 2021
@NicoledeGreef
Copy link
Contributor Author

A more thorough list of things that could be adjusted to French language text is attached. Looking to discuss options for implementation.

french_widget_asks.docx

@qqnluaq
Copy link
Contributor

qqnluaq commented Jan 27, 2021

One way to handle this would be to external-ize all user-facing text in SMK via configuration. Keep the existing text as the default, but provide a way to override any text in the configuration blob.

I'd estimate 3 days for this work

@NicoledeGreef
Copy link
Contributor Author

NicoledeGreef commented Feb 8, 2021

given that there is not a super high demand for multi-language sites in our region, i do not want to commit that amount of effort to externalizing all user-facing text. i am wondering if we could fork the SMK (smk-fr) and adjust the text in that and have the index.html reference the deployed 'smk-fr'. thoughts on benefits/drawbacks/alternatives?

Pros of deploying and using an 'smk-fr':

  • allows us to achieve what client would ideally like to see in relatively short order
  • lower cost to implement

Cons of deploying and using an 'smk-fr':

  • divergent code base; site would not be able to take advantage of latest, greatest features without some effort (e.g. merging smk-fr changes into latest code base each time an upgrade is desired); not sure upgrades would be a requirement but it's a consideration for sure
  • not a step toward "internationalization" of product but this was not an initial goal

@qqnluaq
Copy link
Contributor

qqnluaq commented Feb 10, 2021

Another alternative is to externalize the text in SMK only for the tools that are used by the francophone app, which are:
"type": "toolbar",
"type": "list-menu",
"type": "shortcut-menu",
"type": "pan",
"type": "zoom",
"type": "about",
"type": "layers",
"type": "baseMaps",
"type": "identify",
"type": "search",
"type": "bespoke",
"type": "query",

This is about the same amount work of forking smk and making a fr localized version.
Estimate 2 days

@NicoledeGreef NicoledeGreef changed the title adjusting widget text for French sites adjusting widget text for non-English sites Mar 15, 2021
@NicoledeGreef NicoledeGreef changed the title adjusting widget text for non-English sites adjusting widget text for non-English language sites Mar 15, 2021
@NicoledeGreef NicoledeGreef moved this from For Discussion to To do in SMK 2021-2022 Mar 15, 2021
@NicoledeGreef NicoledeGreef moved this from To do to For Discussion in SMK 2021-2022 Mar 15, 2021
@NicoledeGreef NicoledeGreef moved this from For Discussion to Icebox in SMK 2021-2022 Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

No branches or pull requests

2 participants