Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the default basemap (mentioned in #204) #220

Open
NicoledeGreef opened this issue Mar 9, 2022 · 9 comments
Open

Change the default basemap (mentioned in #204) #220

NicoledeGreef opened this issue Mar 9, 2022 · 9 comments
Assignees
Labels
enhancement New feature or request

Comments

@NicoledeGreef
Copy link
Contributor

To be discussed at meeting on March 9, 2022. The main part of #204 has reached Production already.

@NicoledeGreef NicoledeGreef created this issue from a note in TRP Maintenance (To Do) Mar 9, 2022
@NicoledeGreef NicoledeGreef moved this from To Do to For Discussion in TRP Maintenance Mar 10, 2022
@NicoledeGreef
Copy link
Contributor Author

changing basemap or adding more basemap options is entirely feasible. some full featured basemaps may have cost associated (pay for token to get the most up to date base map, for example) - translink will decide and take costs into consideration.
@gk-tl and @al-tabb to send along specifics of target basemap(s).

@al-tabb
Copy link

al-tabb commented Mar 21, 2022

We'd like to change the default basemap to OpenStreetmap:
https://a.tile.openstreetmap.org/{z}/{x}/{y}.png

Please also keep Stamen Toner Light (current default) as an option in the basemap selector.

michaelpnelson added a commit that referenced this issue Apr 19, 2022
This changes the basemap to be OpenStreetMap, as requested in #220.
@al-tabb
Copy link

al-tabb commented Apr 28, 2022

Should these changes be visible here: https://translink-d.apps.gov.bc.ca/trp/? I still see stamen toner as the default basemap.

@michaelpnelson
Copy link
Contributor

@al-tabb , the changes were abandoned with explanatory comment #223 (comment).

We are working on updating basemaps in SMK as the ESRI legacy basemaps we use are no longer supported. Our plan is to address this issue after SMK basemap updates are ready.

@NicoledeGreef NicoledeGreef moved this from For Discussion to To Do in TRP Maintenance Jun 3, 2022
@NicoledeGreef NicoledeGreef added the enhancement New feature or request label Jun 3, 2022
@michaelpnelson
Copy link
Contributor

I'm moving this to an in-progress status as we are close to finishing our work to use the new ESRI basemap API in pull request #234. Once this is done, we can change the default basemap to be ESRI's hosted OpenStreetMap basemap.

@michaelpnelson michaelpnelson moved this from To Do to In Progress in TRP Maintenance Jun 14, 2022
@michaelpnelson michaelpnelson moved this from In Progress to For Business Review in TRP Maintenance Jun 27, 2022
@michaelpnelson
Copy link
Contributor

Hello @al-tabb! We've updated basemap functionality to use ESRI's new vector basemap API. We've also made OpenStreetMap the default basemap. Changes are deployed to the test environment (https://translink-t.apps.gov.bc.ca/trp/). Please review changes and let us know if they look good to you; if so we will move them into production.

@al-tabb
Copy link

al-tabb commented Jun 27, 2022

Thanks for updating the basemap. Can we hold off on making this change until we address the symbology changes? With the current colour scheme the layers get a bit lost. @NicoledeGreef has there been any discussion around the symbology changes? #221

@al-tabb
Copy link

al-tabb commented Nov 9, 2022

After seeing the new symbology we're actually thinking that Stamen Toner Light might be the best option after all. Are we able to change the default basemap back to Stamen Toner Light? Sorry for the back and forth on this.

michaelpnelson added a commit that referenced this issue Nov 9, 2022
This reverts the change from StamenTonerLight to Streets, originally requested in #220 and updated to restore StamenTonerLight.
michaelpnelson added a commit that referenced this issue Nov 9, 2022
This reverts the change from StamenTonerLight to Streets, originally requested in #220 and updated to restore StamenTonerLight.
michaelpnelson added a commit that referenced this issue Nov 9, 2022
This reverts the change from StamenTonerLight to Streets, originally requested in #220 and updated to restore StamenTonerLight.
michaelpnelson added a commit that referenced this issue Nov 9, 2022
This reverts the change from StamenTonerLight to Streets, originally requested in #220 and updated to restore StamenTonerLight.
@michaelpnelson
Copy link
Contributor

michaelpnelson commented Nov 9, 2022

Hi @al-tabb . I've updated the default basemap to be StamenTonerLight in our dev and qa branches. You can see the changes in the dev server https://translink-d.apps.gov.bc.ca/trp/, but not yet in the test server https://translink-t.apps.gov.bc.ca/trp/. Ben's symbology changes aren't in our qa branch so they weren't included in the redeploy. I've reached out to Ben to see if we can include his changes in the qa branch to get them redeployed to the test server.

This change won't need to be moved to prod as it's still using StamenTonerLight.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
TRP Maintenance
For Business Review
Development

No branches or pull requests

3 participants