Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support FOM soft 'Deleted' as required by Julius #598

Open
9 tasks
MCatherine1994 opened this issue Mar 8, 2024 · 1 comment
Open
9 tasks

Support FOM soft 'Deleted' as required by Julius #598

MCatherine1994 opened this issue Mar 8, 2024 · 1 comment
Labels

Comments

@MCatherine1994
Copy link
Collaborator

MCatherine1994 commented Mar 8, 2024

Describe the task

  • Remove trash icon and disable the delete functionality for FOM with finalized or expired status
  • Make sure ministry user can delete the FOM with commenting closed status
  • Make sure submitter can delete the FOM with initial status
  • Make sure nobody can delete the FOM with published or commenting open status
  • Add a DELETED status to the project status, and FOM with deleted status will be hidden and ignored at all places
  • Change the status of the FOM to "DELETED", and verify they are not shown to user anymore

Acceptance Criteria

  • Add a new DELETED status to the file api/src/app/modules/project/workflow-state-code.entity.ts
  • Regenerate client code for frontend to include the new status
  • Check the method project.service.ts - isDeleteAuthorized() and fom-detail.component.ts canWithdraw() and other methods need to adjust
    • Ministry user - commenting closed - can logically delete
    • Submitter - status initial - can logically delete
    • Status of finalized or expired - logical delete not allowed
    • Status of published or commenting open - logical delete not allowed
  • Change the status of the FOM to "DELETED" when logical delete
  • Check the code and filter out the FOM with "DELETED" status, not return to user

Additional context

  • Future enquiries about deleted FOMS will be answered via database queries; deleted FOMS will never be visible in the user interface.
@MCatherine1994
Copy link
Collaborator Author

FYI, attached the email

Image

@gormless87 gormless87 changed the title Remove FOM record as required by Julius Change FOM status to 'Deleted' record as required by Julius Mar 12, 2024
@MCatherine1994 MCatherine1994 changed the title Change FOM status to 'Deleted' record as required by Julius Support FOM soft 'Deleted' as required by Julius Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant