Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PROD Issue - Batch Job Issue: Published FOMs Did Not Get Switched To Commenting Open On Opening Date. #563

Open
ianliuwk1019 opened this issue Jan 16, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@ianliuwk1019
Copy link
Collaborator

ianliuwk1019 commented Jan 16, 2024

Describe the Bug
Julius reported that a FOM in Published state but commenting opening date is today in production did not get changed to status to be Commenting Open.

Expected Behaviour
Status should be Commenting Open.

Actual Behaviour
Still on Published status.

** Steps To Reproduce**
See screenshot below (Production)

Screenshots
image

Additional context

@ianliuwk1019 ianliuwk1019 added the bug Something isn't working label Jan 16, 2024
@MCatherine1994
Copy link
Collaborator

MCatherine1994 commented Jan 19, 2024

Issue and Solution:

This issue is cased by the cronjob uses wrong image. As shared in #562, the cronjob pulls image from GitHub image registry, uses the latest "test" tag image. However, since we're doing some recent improvement and test deployment, the latest "test" tag image has all our new features. The cronjob argument got changed, so the checks to run the state change cronjob failed and it can't be triggered anymore.

And if we check the api deployment config, it's pulling the image from the Openshift image stream. It uses the latest "test" image when we did prod deployment last time, which is expected and correct.

So in the fix ticket #562, pr #568, we updated the api/openshift.deploy.yml, to let cronjob pull the image from Openshift image stream as well. The workflow works as below:

  • Currently when we merge a pr, it will do test deployment (.github/workflows/merge-main.yml)
  • And when the pr merged to main and closed, it will set "test" tag to the image (.github/workflows/pr-close.yml)
  • When we do prod deployment, it will push the latest "test" tag image from GHCR to Openshift image stream
  • And after prod deployment, it will set the "prod" tag to the latest "test" tag image we used for prod deployment
    So as long as both cronjob and api are pulling image from the Openshift image stream, our test deployment won't impact them anymore. We only push "test" tag image to Openshift image stream when doing prod deployment.

Deployment Condition
We did a PROD deployment on Wednesday to get all business required feature improvement in prod. And that make the cronjob argument works again to trigger the cronjob. So this problem is solved temporarily.

The complete fixes are done in pr #568, and it's merged to main and deployed in test now. We still need to deploy the fix to production to avoid getting the same issue in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants