Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In-session caching #231

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

In-session caching #231

wants to merge 9 commits into from

Conversation

ateucher
Copy link
Collaborator

WIP. Closes #4 when complete

@ateucher
Copy link
Collaborator Author

I think this is failing on GH actions due to the inability to write to the cache directory. Need to detect if on actions, and set option accordingly

@boshek
Copy link
Collaborator

boshek commented Oct 26, 2020

And in case this saves having to look this up, there is an env variable accessible by Sys.getenv("GITHUB_ACTIONS")

@ateucher
Copy link
Collaborator Author

Ok, that's great. Though I guess we could also just set the cache dir in the actions yml. Do you know offhand where we can write? I suppose we could just do it in "." or "./temp"?

@ateucher
Copy link
Collaborator Author

Need to change memoisation pattern like here: r-lib/memoise#76

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Memoise get functions for caching within session
2 participants