Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot get Person Credential (stalls at Step 2) again after deleting. #1954

Open
1 of 5 tasks
loneil opened this issue Apr 25, 2024 · 4 comments
Open
1 of 5 tasks

Cannot get Person Credential (stalls at Step 2) again after deleting. #1954

loneil opened this issue Apr 25, 2024 · 4 comments
Assignees

Comments

@loneil
Copy link

loneil commented Apr 25, 2024

Description of problem

I deleted my Person Cred and when to re-add it I get it stalling at Step 2.

If I back out or close/reopen the app I see the Attestation cred offer(s). Multiple offers if I repeat the steps.
Note I have dev mode on so that's why I see the offer(?)

Trying to manually accept attestation errors out

Expected behavior

Should go on to open my BCSC app

Steps to reproduce

  • Remove Person Cred (note I ran into Unable to delete old credentials (pre W3C/Credo 0.5) #1952, but the cred did delete)

  • Use prompt to re-add person cred

  • Wait at step 2 for a while and then close and reopen app when it does nothing

  • On app open, see the Attestation offer

  • Go in and accept Attestation offer, error

  • Use Person Cred prompt again, repeat loop, see another attestation offer.

Screenshots and/or log output

image

image

image

image

image

Environment

  • Occurs on Android
  • Occurs on iOS

Build #:

1676

Android Device Model:

Pixel 8

iOS Device Model:

Workaround

Severity

  • High
  • Medium
  • Low
@loneil loneil changed the title Error when trying to get Person Credential again after deleting. Error (stalls at Step 2) when trying to get Person Credential again after deleting. Apr 25, 2024
@loneil
Copy link
Author

loneil commented Apr 25, 2024

After accepting the Attestation cred, with the error, I can get through Step 2 of the person cred flow.
Not sure if this has anything to do with my attempting to accept the Attestation cred or not, or something ephemeral happened.

But when going through the BCSC flow and authorizing successfully there I now get this error coming back:

image

It did revoke my Person Cred on my iPad (other device I had the cred on) as part of this.

@loneil loneil changed the title Error (stalls at Step 2) when trying to get Person Credential again after deleting. Cannot get Person Credential (stalls at Step 2) again after deleting. Apr 25, 2024
@loneil
Copy link
Author

loneil commented Apr 25, 2024

I ended up on this state on my iPad on 1636 as well. Could not get past Step 2 (spinning and not prompting for BCSC app login or anything).

The case on the iPad was that I'd had the cred revoked, removed it and tried to get it again as well.

Uninstalling and Reinstalling the BC Wallet app allowed me to proceed on the iPad and get the cred successfully.

I tried to reproduce this case on the iPad by revoking (through id.gov.bc.ca), removing, and re-adding, but it worked fine that time. So I'm not sure what state it was in when failing right before that...

Android Phone remains in broken state at this time. Can't get Person Cred on it and have not re-installed app yet.

@cvarjao cvarjao mentioned this issue May 1, 2024
13 tasks
@esune
Copy link
Member

esune commented May 2, 2024

I see this error also with a different Credential (LCRB SIR on CANdy Test): I receive the offer, but get an error when I try to accept it.
Media

@cvarjao cvarjao added this to the release 1.0.17 milestone May 3, 2024
@bryce-mcmath bryce-mcmath self-assigned this May 16, 2024
@bryce-mcmath
Copy link
Contributor

I believe this issue is fixed by the same PR that addressed #1966 , moving to QA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants