removed redundant throws clause in X509v3CertificateBuilder #1581

kuzjka · 2024-02-08T08:12:08Z

Resolves #1580

X509v3CertificateBuilder has overloaded addExtension methods, which call ExtensionsGenerator under the hood.

If the extension is constructed from OID, critical flag and encoded extension value, ExtensionsGenerator may throw CertIOException if an IOException occurs during construction of the extension.

However, if Extension object is passed - no IOException can occur inside ExtensionGenerator and it doesn't throw CertIOException as well.

bc-java/core/src/main/java/org/bouncycastle/asn1/x509/ExtensionsGenerator.java

Lines 119 to 134 in 9279d29

    
               /** 
        
                * Add a given extension. 
        
                * 
        
                * @param extension the full extension value. 
        
                */ 
        
               public void addExtension( 
        
                   Extension extension) 
        
               { 
        
                   if (extensions.containsKey(extension.getExtnId())) 
        
                   { 
        
                       throw new IllegalArgumentException("extension " + extension.getExtnId() + " already added"); 
        
                   } 
        
                   extOrdering.addElement(extension.getExtnId()); 
        
                   extensions.put(extension.getExtnId(), extension); 
        
               }

Therefore, this checked exception throws clause is redundant in X509v3CertificateBuilder.

dghgit · 2024-03-16T23:05:24Z

I'll admit this is a bit painful, but we need to leave this as it is for now - the issue with the checked exception is removing it will mean all existing code will need to be changed and it will be very difficult to add the checked exception back in the case where further validation of extension contents turns out to be necessary. Rock and a hard place.

removed redundant throws clause in X509v3CertificateBuilder

dfa9dac

dghgit self-assigned this Feb 11, 2024

dghgit closed this Mar 16, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

removed redundant throws clause in X509v3CertificateBuilder #1581

removed redundant throws clause in X509v3CertificateBuilder #1581

kuzjka commented Feb 8, 2024

dghgit commented Mar 16, 2024

	/**
	* Add a given extension.
	*
	* @param extension the full extension value.
	*/
	public void addExtension(
	Extension extension)
	{
	if (extensions.containsKey(extension.getExtnId()))
	{
	throw new IllegalArgumentException("extension " + extension.getExtnId() + " already added");
	}

	extOrdering.addElement(extension.getExtnId());
	extensions.put(extension.getExtnId(), extension);
	}

removed redundant throws clause in X509v3CertificateBuilder #1581

removed redundant throws clause in X509v3CertificateBuilder #1581

Conversation

kuzjka commented Feb 8, 2024

dghgit commented Mar 16, 2024