Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 [BUG]: Auto-generated Handle ids change with position #1393

Open
1 task done
bcakmakoglu opened this issue May 6, 2024 · 0 comments
Open
1 task done

馃悰 [BUG]: Auto-generated Handle ids change with position #1393

bcakmakoglu opened this issue May 6, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@bcakmakoglu
Copy link
Owner

Is there an existing issue for this?

  • I have searched the existing issues and this is a new bug.

Current Behavior

Currently, if a handle is not explicitly assigned an id, one will be auto-generated.
The auto-generated id depends on the position of a handle, which causes edges created to those handles to fail their handle lookup if the position prop of the handle is changed after the edge was already created.

Expected Behavior

Handles should not require an id as long as not multiple of the same type (source / target) are used.
Furthermore handles should not auto-generate an id themselves if no id was explicitly passed, allowing us to fall back to the first handle of each type when looking up an edges' handles.

Steps To Reproduce

  1. Create an edge between two nodes
  2. Change the handle position of the nodes
  3. Update node internals to signal the position change
  4. Edge does not update to the new handle positions

Relevant log output

No response

Anything else?

This might be a breaking change since existing users might expect handle ids to pop up with new connections as that's the current behavior.

This change might be pushed into the next major release to avoid breaking existing users apps.

@bcakmakoglu bcakmakoglu added bug Something isn't working triage Awaiting triage labels May 6, 2024
@bcakmakoglu bcakmakoglu self-assigned this May 6, 2024
@bcakmakoglu bcakmakoglu removed the triage Awaiting triage label May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant