Skip to content
This repository has been archived by the owner on Oct 21, 2021. It is now read-only.

WIP: Implement Inferno V6 support #20

Closed
wants to merge 5 commits into from
Closed

Conversation

IgnusG
Copy link
Contributor

@IgnusG IgnusG commented Oct 19, 2018

Fragments are still under development

Resolves #16

@IgnusG IgnusG force-pushed the inferno-v6 branch 5 times, most recently from 9edb1d4 to f41cb46 Compare October 20, 2018 14:24
@IgnusG
Copy link
Contributor Author

IgnusG commented Oct 20, 2018

So that seemed ... easy (suspicious..)? I will need to bring fragment tests over to inferno adapter's original specs so everything is covered. I manually tested it with a few examples that came to my mind and everything worked fine so far

- Small change in enzyme adapter (render no longer returns anything)
- Rewritten to tree completely to make code more readable and less error
prone.

toTree handles the complete logic of deciding what to do with
which component types (it trusts getNodeType to report the correct type).

getNodeType handles corrections for types and uses types of children &
inferno's flags in order to decide.

Adding or configuring types should be as straightforward as teaching the
later how to properly distinguish this type and the former how to create
an appropriate tree representation based on this.
It takes inspiration from the design of the official react 16 adapter from enzyme.
So it's easier to change their name and their respective node
representation types - which can change across enzyme releases.
To improve extensibility in the future. I would like all methods inside
toTree which either adjust rendered or instance to follow the same
naming scheme as separate (extracted) functions.
Will still need to add tests from official enzyme repo.
@IgnusG
Copy link
Contributor Author

IgnusG commented Aug 21, 2019

Closing due to time constraints and interest shift

@IgnusG IgnusG closed this Aug 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fragments - Inferno 6
1 participant