Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vertical video #195

Open
pietrop opened this issue Mar 17, 2020 · 8 comments
Open

Vertical video #195

pietrop opened this issue Mar 17, 2020 · 8 comments

Comments

@pietrop
Copy link

pietrop commented Mar 17, 2020

馃憢Hello,
Can VideoContext handle vertical video (eg from a phone)? I did a test and it seemed to stretch it side to side...

@yakca
Copy link
Member

yakca commented Mar 18, 2020

Hi @pietrop

Running a test locally with a phone recording does suggest we aren't using the rotation metadata which confirms your results.

Looking back at previous issues - #155 - the challenge is that we don't have access to the rotation metadata within JavaScript.

I'd certainly welcome a pull request/contribution if you find a sensible approach or workaround that we can document. Otherwise, this is something I'll note as TODO.

@emettely
Copy link

Hey @bevand10, do you have any thoughts on this? :)

@pietrop
Copy link
Author

pietrop commented Mar 18, 2020

Thanks @yakca,
It seems like with ffprobe and exiftool it might be possible to get the rotation ("server side" in node) - "Inspect Video Orientation using Node & fluent-ffmpeg, ExifTool, or MediaInfo"

So was wondering, could there be an optional attribute in the segments of the sequence/playlist/edl eg 'rotation'? And if that's present VideoContext behaves accordingly?

@pietrop
Copy link
Author

pietrop commented Mar 18, 2020

Also I remember @chrisbaume a while back mentioned using mediainfo lib github.com/buzz/mediainfo.js(demo mediainfo.js.org) and that seems to return a rotation attribute 馃槷

Screen Shot 2020-03-18 at 11 43 52 AM

@yakca
Copy link
Member

yakca commented Mar 19, 2020

mediainfo looks promising, looks the native transpile is the key there.

@pietrop
Copy link
Author

pietrop commented Mar 19, 2020

ok, just to get an overview, do you know once figured out that first part of getting the rotation metadata info, what else would need to be changed(and where, in the code) for VideoContext to take it into account when showing a clip?

@pietrop
Copy link
Author

pietrop commented Mar 19, 2020

Also was just looking that, canvas.rotate and canvas.transform might come in handy unless you already have some other way in mind?

@yakca
Copy link
Member

yakca commented Apr 7, 2020

Hi @pietrop - sorry for the delay. It will be a month or two before I can personally look at adding this as a feature. The canvas transformation may be useful but it isn't an area I'm familiar with in VC yet. We are in something of a transition phase between maintainers; it is now @emettely and myself and we are both relatively new to the project.

If you get something working, we'd certainly be happy to look at a pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants