Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default_features = False not respected in bzlmod #2595

Closed
firekind opened this issue Apr 1, 2024 · 2 comments
Closed

default_features = False not respected in bzlmod #2595

firekind opened this issue Apr 1, 2024 · 2 comments

Comments

@firekind
Copy link

firekind commented Apr 1, 2024

Hello,
I have a non cargo setup via bzlmod. When i set default_features = False in crate.spec for a crate (in this case, the ort crate), the rust_library target generated in the crate's BUILD file still has the crate_features attribute set. This does not seem to happen if I use WORKSPACE instead of bzlmod.

@firekind
Copy link
Author

firekind commented Apr 1, 2024

here's a simple repro

@firekind
Copy link
Author

This was fixed by #2606, so closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant