Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error stamping for maven target on windows #980

Open
werkt opened this issue Oct 15, 2023 · 1 comment
Open

Error stamping for maven target on windows #980

werkt opened this issue Oct 15, 2023 · 1 comment

Comments

@werkt
Copy link

werkt commented Oct 15, 2023

(16:05:46) INFO: From Compiling compiler/src/java_plugin/cpp/java_generator.cpp [for tool]:
--
  | C:\b\54t5nytv\execroot\build_buildfarm\external\io_grpc_grpc_java\compiler\src\java_plugin\cpp\java_generator.h(35) : warning C4722: 'LogHelper::~LogHelper': destructor never returns, potential memory leak
  | (16:05:47) ERROR: C:/b/yechmtpy/external/maven/BUILD:3188:11: Stamping the manifest of @maven//:org_projectlombok_lombok [for tool] failed: failed to delete output files before executing action

Seems spurious, happy to see a redirect if this is a bazel side failure: https://buildkite.com/bazel/buildfarm-farmer/builds/6855

@werkt
Copy link
Author

werkt commented Nov 20, 2023

I've had to resolve this by adding --@rules_jvm_external//settings:stamp_manifest=False to my windows builds. This was enabled by default in c8c8a87 and seems to generate some odd behavior on windows systems that is in conflict with reliable pre-action output deletions that bazel expects to be able to perform. @lukaciko for default enable and @jin for original introduction of the setting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant