Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flags underneath rules/flags/ aren't working correctly #229

Open
Bencodes opened this issue May 7, 2024 · 1 comment
Open

Flags underneath rules/flags/ aren't working correctly #229

Bencodes opened this issue May 7, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@Bencodes
Copy link
Contributor

Bencodes commented May 7, 2024

I'm able to find the flags with Bazel query:

❯ ./bazelw query @rules_android//rules/flags:all
(16:59:19) INFO: Current date is 2024-05-06
@rules_android//rules/flags:all_files
@rules_android//rules/flags:android_enable_res_v3
@rules_android//rules/flags:bzl
@rules_android//rules/flags:debug
@rules_android//rules/flags:enable_splits
@rules_android//rules/flags:flags
@rules_android//rules/flags:manifest_merge_order
@rules_android//rules/flags:mi_dogfood
@rules_android//rules/flags:mi_v3
@rules_android//rules/flags:min_sdk_version
@rules_android//rules/flags:num_dex_shards
@rules_android//rules/flags:runfiles_root_prefix
@rules_android//rules/flags:stamp
@rules_android//rules/flags:stamp_off
@rules_android//rules/flags:stamp_on
@rules_android//rules/flags:use_adb_root
@rules_android//rules/flags:use_custom_dex_shards
@rules_android//rules/flags:use_direct_deploy
@rules_android//rules/flags:use_studio_deployer

But i'm unable to use the vast majority of them:

➜ ./bazelw build //apps/rider:bin_devRelease --@@rules_android//rules/flags:min_sdk_version=10
(17:03:04) ERROR: Skipping '@@rules_android//rules/flags:min_sdk_version': no such target '@@rules_android//rules/flags:min_sdk_version': target 'min_sdk_version' not declared in package 'rules/flags' defined by /private/var/tmp/_bazel_blee/499a001013731d09bffd82f8601a3161/external/rules_android/rules/flags/BUILD
(17:03:04) ERROR: @@rules_android//rules/flags:min_sdk_version :: Error loading option @@rules_android//rules/flags:min_sdk_version: no such target '@@rules_android//rules/flags:min_sdk_version': target 'min_sdk_version' not declared in package 'rules/flags' defined by /private/var/tmp/_bazel_blee/499a001013731d09bffd82f8601a3161/external/rules_android/rules/flags/BUILD

The flag that does seem to work is @rules_android//rules/flags:manifest_merge_order which is registered as an individual attribute on the rules vs. the rest of the flags which are wrapped up in the @rules_android//rules/flags:flags attribute.

@ahumesky ahumesky added the bug Something isn't working label May 7, 2024
@timpeut
Copy link
Collaborator

timpeut commented May 7, 2024

It is not intended that you can explicitly set min_sdk_version on the command line. It exists so that it can be used as an internal implementation detail, but this is not fully wired up and functional.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants