Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Average price vs FIFO #3

Open
miradorcrypto opened this issue Jul 30, 2018 · 1 comment
Open

Average price vs FIFO #3

miradorcrypto opened this issue Jul 30, 2018 · 1 comment

Comments

@miradorcrypto
Copy link

Hi !

First of all, thanks for your great work !

Just you know, I've been in contact with a tax lawyer who told me that the computation method needed for the "same day rule" and "bnb" is actually average price and not fifo.

Have you heard about this ? Did you choose FIFO arbitrarily ? Do you have any recommandation to modify the code in order to fit with average price computation ?

Thanks !

@baxter100
Copy link
Owner

baxter100 commented Jul 31, 2018

cheers!

I had considered this but couldn't find anywhere explicitly stating what it should be and it seemed easier to use FIFO for the same day and bnb rules. In fact I remember we mentioned this here

Regarding altering the code, it's been some time since I've done any work on it so I can't think of any easy modifications of the top of my head. We did make it to use average price for the 404 holdings rule, so you may just be able to use some of those functions to help you

I'll put it on the list of things to do!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants