-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Performance detection bug #785
Comments
Hi @patrob1! |
Hi @bartlwojcik ! |
Hi @bartlwojcik, The If this happens only in Firefox, do you have any filters, animations, etc.? Example on SVGs? or other elements? at initial call. Alternatively you could set a There is also the possibility to adjust the values, but it is not recommended, because these are tuned to Lighthouse ;) These can be overwritten in the module options. {
runOptions: {
maxTime: 1000,
threshold: 0.65
}
} |
@patrob1 Thanks for your response, will definitely give it a try :) Hi @ThornWalli! |
@bartlwojcik Try to start the video in mounted. Assume But you might need a poster in the video now. This can be a reason. |
Describe the bug
On weaker devices, if I set the detection.performance property to true, the page doesn't load the additional resources after the initial page load, so it stops working. If I turn off performance detection or set very high fcp & dcl to always meet the requirements, than it is highly reducing the performance by leaving a 22mb generated chunk in the initial payload. With performance detection and the following options, the page is fast, but doesn't work on weaker devices at all. It is also happening when I don't include the SpeedkitLayer in the code.
I thought that the forceInit option is for this purpose but for me it makes no difference.
To Reproduce
I have the following setup:
`speedkit: {
detection: {
performance: true,
browserSupport: true
},
forceInit: true,
performanceMetrics: {
device: {
hardwareConcurrency: { min: 2, max: 48 },
deviceMemory: { min: 2 }
},
timing: {
fcp: 800,
dcl: 1200
}
},
Expected behavior
Continue page loading in case the performance requirements not met.
The text was updated successfully, but these errors were encountered: