Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default style class from SpeedkitImage & SpeedkitPicture #665

Open
woolimi opened this issue Jul 25, 2022 · 1 comment
Open

Remove default style class from SpeedkitImage & SpeedkitPicture #665

woolimi opened this issue Jul 25, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@woolimi
Copy link

woolimi commented Jul 25, 2022

Describe the bug
Hello!
I was trying to migrate nuxt-img component to SpeedkitImage, and then realized that legacy styles are all broken.
That's caused by the own style of SpeedkitImage like below

<style lang="postcss" scoped>
/*! purgecss start ignore */
.nuxt-speedkit-image {
  content-visibility: auto;
  display: block;
  width: 100%;
  height: auto;
  object-fit: cover;
}
/*! purgecss end ignore */
</style>

However, I think this class should be removed and let user decide style.

Expected behavior

Remove default style and let user customize styling on their own.

@Triloworld
Copy link
Contributor

Triloworld commented Jul 27, 2022

Propose to add:
Option: defaultCss
By default true and can be disabled - to easily update in minor version without breaking existing stuff
Change to false to have components without any: styles or css files
Will be nice and sufficient to remove that code.

Better solution is to have major version without styles that is better aligned to any design guid lines :) Easily and nicely without overhead

@ThornWalli ThornWalli added the enhancement New feature or request label Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants