Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify precision loss #58

Open
epociask opened this issue May 24, 2023 · 1 comment
Open

Verify precision loss #58

epociask opened this issue May 24, 2023 · 1 comment
Assignees
Labels
good first issue Good for newcomers type: bug Something isn't working

Comments

@epociask
Copy link
Collaborator

Problem

The current code for converting wei to ether in the given acount_balance oracle definition has a potential issue of precision loss since the returned overflow/underflow byte is unchecked. This can lead to inaccurate conversion results and affect the accuracy of the overall calculations.

Solution

To ensure accurate conversion from wei to ether, it is necessary to verify the precision loss in the existing code implementation. This can be addressed by performing thorough testing and validation.

@epociask epociask added good first issue Good for newcomers type: bug Something isn't working labels May 24, 2023
@ProfParadox123
Copy link

Can we use fixed-point arithmetic ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants