Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify config validity during HeaderTraversal construction #21

Open
anupsv-cb opened this issue Apr 14, 2023 · 0 comments
Open

Verify config validity during HeaderTraversal construction #21

anupsv-cb opened this issue Apr 14, 2023 · 0 comments
Assignees
@epociask
Labels
good first issue Good for newcomers type: bug Something isn't working type: enhancement New feature or request

Comments

@anupsv-cb
Copy link
Contributor

Problem

Currently, the passed in block heights and their validity are being checked at the functions where they shouldn't have to worry about it. The configs need to be verified when the oracle is asked to be constructed.

Proposed Solution (Conveyor Component)

When the NewOracle function is called, we need to verify if the configs are valid and throw respective errors if they're not.
@anupsv-cb anupsv-cb mentioned this issue Apr 14, 2023
Merged
@epociask epociask added type: bug Something isn't working type: enhancement New feature or request good first issue Good for newcomers labels Apr 14, 2023
@epociask epociask changed the title Verify config validity during Oracle construction Verify config validity during HeaderTraversal construction Nov 7, 2023
@epociask epociask mentioned this issue Nov 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@epociask epociask

Labels
good first issue Good for newcomers type: bug Something isn't working type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@epociask @anupsv-cb