Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat - Hash Verification #187

Open
epociask opened this issue Nov 7, 2023 · 0 comments
Open

Feat - Hash Verification #187

epociask opened this issue Nov 7, 2023 · 0 comments
Assignees
Labels
type: enhancement New feature or request

Comments

@epociask
Copy link
Collaborator

epociask commented Nov 7, 2023

Problem

The withdrawal_safety heuristic currently verifies that a CrossDomainHash is reflective of a standard 256 bit hexadecimal hash output. This is done by taking the Sorensen Dice coefficient to ensure dissimilarity when compared to constant values (0x0...0, 0xF...F). Currently this check happens in the heuristic directly and fails to consider for additional constant values.

Problem Solution

Add some HashVerification function into the common/math library that performs integrity checks to verify if a value is reflective of a real hash output. This can extend on the existing implementation or leverage more intelligent techniques.

@epociask epociask added the type: enhancement New feature or request label Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants