Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make betty.config.Configuration.load() an instance method #1372

Open
bartfeenstra opened this issue Apr 5, 2024 · 0 comments · May be fixed by #1512
Open

Make betty.config.Configuration.load() an instance method #1372

bartfeenstra opened this issue Apr 5, 2024 · 0 comments · May be fixed by #1512
Labels
BC break Breaks backwards compatibility with existing integrations enhancement New feature or request python Pull requests that update Python code
Milestone
0.4.0

Comments

@bartfeenstra
Copy link
Owner

bartfeenstra commented Apr 5, 2024 •
edited

Make betty.config.Configuration.load() an instance method. This will require calling code to create this new instance first, but that allows for:

  • the configuration's initializer to ensure required arguments are available
  • load() to pass on these arguments to any new instance it creates, possibly overridden by the loaded configuration

Blocked by

  • The 0.4.x branch being opened
@bartfeenstra bartfeenstra added enhancement New feature or request BC break Breaks backwards compatibility with existing integrations python Pull requests that update Python code labels Apr 5, 2024
@bartfeenstra bartfeenstra added this to the 0.4.0 milestone Apr 5, 2024
@bartfeenstra bartfeenstra modified the milestones: NEXT, 0.4.0 May 19, 2024
This was referenced May 19, 2024
Draft
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
BC break Breaks backwards compatibility with existing integrations enhancement New feature or request python Pull requests that update Python code
Projects
None yet
Milestone
0.4.0
Development

Successfully merging a pull request may close this issue.

Make Configuration.load() an instance method bartfeenstra/betty
1 participant
@bartfeenstra