Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suggestion: add missing translation with default text for default locale. #434

Open
yob-yob opened this issue Nov 11, 2022 · 2 comments
Open
Labels

Comments

@yob-yob
Copy link

yob-yob commented Nov 11, 2022

Hi, Just a suggestion and may need some more input... but if you can detect missing translations, and add the translation key to the database so that it can be translated... why don't the package also just add in a default text as well??

say we have this kind of code __('file.parent.child.key', ['param' => 'example'], 'Default text here as :param')

a cons that I could think of is that this default text would just only be used once in the code, making it something not really that necessary.

@baqar-hassan
Copy link

It would help if you used the fallback language. See the docs

Additionally, you may configure a "fallback language," which will be used if the active language does not contain a certain language line. The fallback language is also defined in the app/config/app.php configuration file, as is the default language.
'fallback_locale' => 'en',

@stale
Copy link

stale bot commented Jun 18, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If this issue is still present on the latest version of this library on supported Laravel versions, please let us know by replying to this issue so we can investigate further.
Thank you for your contribution! Apologies for any delayed response on our side.

@stale stale bot added the stale label Jun 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants