Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to export groups in subfolders #422

Closed
wants to merge 3 commits into from
Closed

Make it possible to export groups in subfolders #422

wants to merge 3 commits into from

Conversation

HarryThe3rd
Copy link
Contributor

One change from #417 broke the export function for translations in subfolder.
This change reverts one line to mitigate this issue.

fixes #406

Harry Werkmeister and others added 3 commits March 15, 2022 09:01
This fix makes it possible that folder structures used in translation strings are used as group keys.
@sgacode
Copy link

sgacode commented Jan 18, 2023

It would be great to merge this changes into master:
1a0420b

At moment export for vendor packages is not working.
For example we have messages with group vendor/package in DB.
After applying $group = basename("vendor/package") $group will be package.
Messages for group package will not be found in DB and $vendor will be false

@nickjedwards
Copy link

Hi @barryvdh , is there an outstanding reason this cannot be merged? I'm happy to put together a PR with any relevant changes 👍

@barryvdh
Copy link
Owner

Yes this was a security issue to prevent path traversal. Maybe we can fix it another way though.

@nickjedwards
Copy link

Thanks for the prompt reply @barryvdh ! any chance you could explain the relevance of files changed in #417 , I don't get the connection 😅

Are you also able to demonstrate (explain) the "path traversal" vulnerability? I'm happy to suggest a solution, but currently don't know how to replicate/test the vulnerability

@HarryThe3rd HarryThe3rd closed this by deleting the head repository Dec 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Translations in folders are not imported
4 participants