Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translations in folders are not imported #406

Open
AlexKomMsk opened this issue Dec 24, 2021 · 9 comments
Open

Translations in folders are not imported #406

AlexKomMsk opened this issue Dec 24, 2021 · 9 comments
Labels

Comments

@AlexKomMsk
Copy link

I have a translation in a folder writer/messages.php
This translation is not imported into the database. All translations in folders are not imported into the database. Translations without folders are successfully imported.

@HarryThe3rd
Copy link
Contributor

The Problem is that the group pattern does not match with folders included in the translation string.
I have a fix for this and will create a pull request.

barryvdh pushed a commit that referenced this issue Mar 17, 2022
This fix makes it possible that folder structures used in translation strings are used as group keys.

Co-authored-by: Harry Werkmeister <h.werkmeister@careerpartner.eu>
@simonjolsen
Copy link

So for me, the import from folders are now working, but publishing the translations in folders are not. It says it's successful, but it's not updating the file. If the file is not in a folder. It works.

@underdpt
Copy link

Yeah, I also have the issue that publishing translations in folders are not working. It works when downgrading to 0.6.2

@stale
Copy link

stale bot commented Jul 10, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If this issue is still present on the latest version of this library on supported Laravel versions, please let us know by replying to this issue so we can investigate further.
Thank you for your contribution! Apologies for any delayed response on our side.

@stale stale bot added the stale label Jul 10, 2022
@maxi032
Copy link

maxi032 commented Jul 14, 2022

For me exporting the translations did not worked with wither 0.6.2 nor with 0.6. 3.

php artisan translations:export --all
Done writing language files for ALL groups

There was no change
I am using Laravel 8.83

@maxi032
Copy link

maxi032 commented Jul 14, 2022

For me exporting the translations did not worked with wither 0.6.2 nor with 0.6. 3. php artisan translations:export --all Done writing language files for ALL groups There was no change I am using Laravel 8.83

I had it working with v0.5.10 after I deleted composer.lock

@stale stale bot removed the stale label Jul 14, 2022
@stale
Copy link

stale bot commented Sep 21, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If this issue is still present on the latest version of this library on supported Laravel versions, please let us know by replying to this issue so we can investigate further.
Thank you for your contribution! Apologies for any delayed response on our side.

@stale stale bot added the stale label Sep 21, 2022
@martinschenk
Copy link

martinschenk commented Oct 20, 2022

i have the same issue. Not exporting to folders. :(
Import works well.
My folder is: lang/vendor/cookie-consent/en/texts.php
and not exporting to lang/vendor/cookie-consent/de/texts.php
But says: "Done writing language files for vendor/cookie-consent group"

and
php artisan translation:export vendor/cookie-consent -vvv
does not show more output.

@stale
Copy link

stale bot commented Jun 18, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If this issue is still present on the latest version of this library on supported Laravel versions, please let us know by replying to this issue so we can investigate further.
Thank you for your contribution! Apologies for any delayed response on our side.

@stale stale bot added the stale label Jun 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants