Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is an async version planned? #111

Open
StandingPadAnimations opened this issue May 31, 2021 · 4 comments
Open

Is an async version planned? #111

StandingPadAnimations opened this issue May 31, 2021 · 4 comments

Comments

@StandingPadAnimations
Copy link

It's a awesome library, but I think an async version would benefit a lot of people. Currently, to use it in a async program the run_in_executor loop is needed. Is an async version ever planned in the future?

@barrust
Copy link
Owner

barrust commented Aug 29, 2022

I think an async version would be great. Unfortunately I do not have time at the moment to dedicate to converting it to async, but pull requests or any sort of help would be greatly appreciated!

@EasternJournalist
Copy link

EasternJournalist commented May 22, 2023

I think an async version would be great. Unfortunately I do not have time at the moment to dedicate to converting it to async, but pull requests or any sort of help would be greatly appreciated!

It's really an awesome and convenient library, which I appreciate. But unfortunately I have high demands for concurrent requests. Therefore I implemented a low-level asynchronized wrapper for my own use https://github.com/EasternJournalist/wikiapi/blob/master/async_api.py. Maybe these experience helps. Is the async version still on the plan? If so, I wish to create a pull request and contribute an async version.

@barrust
Copy link
Owner

barrust commented May 22, 2023

I would love an async version, but haven't had the time to get around to it. Any help or Pull Request would be appreciated!

@StandingPadAnimations
Copy link
Author

2 years on from when I requested this, I think I might be able to start on an async version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants