Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for files (URL, uploading user, etc) #108

Open
ghost opened this issue Feb 20, 2021 · 1 comment
Open

Support for files (URL, uploading user, etc) #108

ghost opened this issue Feb 20, 2021 · 1 comment

Comments

@ghost
Copy link

ghost commented Feb 20, 2021

Hiya, I was wondering if this project has a place for wrapping some file-related information.

Now, I forked this repository and added wrapping for a given file's URL, but I was wondering if this sort of functionality has enough merit and reason to add to the main project before I create a pull request.

I haven't added any tests yet, but if it'll be okay I'll go ahead and add some.
Thank you 🙂

@barrust
Copy link
Owner

barrust commented Feb 22, 2021

I do think there is a place for file support in the base library. I would like to figure out how best to incorporate files into the library.

Some thoughts on the code you linked:

  • What are you hoping to get out of the files? Just a listing of available files on the page?
  • Is there a reason that a new class is needed? If so, I don't think we would need to base the mediawikifile class on the mediawikipage class but I haven't had time to think it through in-depth.
  • Would it be easier to have a boolean property to say that the page is a file?
  • In non-english versions, is the term that signals the page is a file always File:? I know that for categories it can be other words/terms/etc.

Thanks for starting this discussion. I am excited to see where this goes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant