-
Notifications
You must be signed in to change notification settings - Fork 458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
query re: support for EOL versions of PHP #465
Comments
@barbushin initially wanted to keep the support for these PHP versions. In my opinion we can remove the support for all unsupported PHP versions: https://www.php.net/supported-versions.php So I would only support active PHP versions such as PHP 7.2 and newer/higher. We also somehow need to force users to update their old stuff. When they always see, that the software is still supported with an older version, they will never update their system as it's working. Some coding improvements of this library are even only possible, when we remove the support for older versions, so we should think about removing support for EoL PHP versions. Any feedback / suggestions? @bapcltd-marv @barbushin |
@Sebi94nbg re: code improvements, see:
If you wanted to jump straight to Our downstream fork jumps straight to Of the dependant packages listed in packagist,
You could consider supporting a pair of p.s. advantages of jumping to 7.4 are the typed properties & being able to reasonably include a composer.lock file in the repo. |
Ok, let's remove the no longer supported PHP versions. Jumping directly to PHP 7.4 supported code, would be awesome, but I want to keep the support for PHP 7.2 and 7.3. |
I'd imagine you'd want to put a new 3.x release out before I PR the appropriate branch for a 4.x release? by the sounds of it, you'd be wanting the "drop/php-7.1" branch (not PRing yet due to recurring habit of rebasing it/tweaking the patch set). re: "forcing" users to upgrade, I'm not sure I have any relevant experience to comment appropriately beyond support policies on 3.x/4.x. |
p.s. update on 19 unlisted php constraints:
(may have miscounted one of the 2.x/3.x counts) |
further thoughts:
|
Mhmm, I would exclude PHP 8 in this case for now. Excluding PHP 7.2+ is no good idea at all and all PHP 7 versions as well not. |
the idea behind |
practical example:
which leads to a lower constraint being applied to tl:dr; lowering the upper bound of php supported for 3.x may force uses to upgrade, and could lead to user frustration. |
It's always kinda complicated to avoid frustating users. :( |
@bapcltd-marv what's the plan now? When can we publish all your improvements with which version? |
current plan is:
p.s. see also optionally providing guidance for getting some of the private tests into the repo in some form or another. |
@bapcltd-marv everything ready in the |
@Sebi94nbg are we doing anything with integrating your private tests into the repo? |
The most of these tests are already in the repo. I just double-checked them before all the time since I never was sure, that the repo tests were working as expected. So, I would now merge |
@bapcltd-marv did I miss anything regarding what changed? #491 |
looks good :) |
Released 3.1.0! :) |
if you can fork & remove oauth from develop, I can get to rebasing #475 once I'm done watering the office plants. |
Sure, I'll do that in around one hour. I'll get some ice cream first. :) |
I've unfortunately some trouble with pulling/pushing from/to Git from my local system. I need to investigate this issue further. :'( |
what's the messages you're getting ? |
Sorry for the delay, I am still moving to my new flat and that will last until the end of May due to COVID-19. I could now partitially fix the issue with Git / VSCode. It was always reporting, that the SSH key couldn't be loaded or used for authentication or that the host key could not be verified. At the moment, I can run I've now removed the OAuth code from the develop branch (commit f85a74) and created a new branch based on the develop branch, which includes the OAuth code: develop...411-OAuth-Support |
|
Ok, I've merged your PR re dropping old PHP support. And also implemented the code change from the other PR regarding this Base 64 decoding. Are we ready to release It would be nice, when we could have a successful build: https://travis-ci.org/github/barbushin/php-imap/jobs/676976779 :D |
dropping php versions should be a major release, not a minor release, i.e. 4.0.0 |
Yeah, you're right. Should be a major release as it drops old PHP support. Any idea, how we can fix this Travis CI issue? Is anything else todo except the fix for Travis CI? |
travis was down for maintenance earlier, couldn't see the error; |
I've added that typecast, thanks. I've added a table regarding the supported PHP versions to the README: https://github.com/barbushin/php-imap/blob/develop/README.md
If I didn't miss anything, I'll publish this PR #493 as |
the readme isn't entirely accurate re: ext-iconv; both it and ext-mbstring are presently required in composer.json- installation will fail without them. |
Updated! Anything else, what I missed? |
|
Interesting. No clue, where I got this FR1-thing from. Can't find it anymore. :o
Nope, weren't mentioned. See https://github.com/barbushin/php-imap/releases. I've updated the README:
When the build is not failing, I'll then release the new version |
Released v4.0.0. :) |
I was just wondering what the plans are for supporting php 5.6/7.0/7.1, given that they're all EOL?
The text was updated successfully, but these errors were encountered: