Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Theme Selection Process #67

Closed
imsachin49 opened this issue May 4, 2024 · 2 comments
Closed

Improve Theme Selection Process #67

imsachin49 opened this issue May 4, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@imsachin49
Copy link
Contributor

  • Currently, accessing available themes requires scrolling through the home page. To streamline this process, we can implement a scrollbar specifically for browsing available themes on the theme section only. This will offer users a more efficient and organized way to explore our selection of themes.

  • Additionally, I suggest enhancing the user experience by implementing the feature where clicking the theme button toggles the visibility of the theme list. This way, users can easily open and close the theme list without having to navigate away.

  • I've created a video demonstrating the issue. You can watch it here.

  • I'm interested in working on this issue and would like to contribute to the project. Could this issue be assigned to me? I believe I can effectively implement these improvements and ensure a better user experience. Looking forward to collaborating with the team on this.

    Thank you!

@baoliay2008
Copy link
Owner

@imsachin49 Thank you for your suggestion.

  • About the scrollbar, while I don't think it's necessary, there's no harm in adding one. We welcome a pull request if you'd like to contribute.

  • For clicking the theme button to toggle the visibility of the theme list, I understand what you're looking for. You'd like it to work similarly to the <details> tag. Although I don't see it as critical, we'd be happy to consider a pull request if you want to propose a solution.

imsachin49 added a commit to imsachin49/lccn_predictor that referenced this issue May 7, 2024
baoliay2008 pushed a commit that referenced this issue May 20, 2024
…heme list (pull #68)

* Fix issue #67: added scroller to theme list

* 🐛 fix: Add event listener to close dropdown when clicking outside; remove onBlur event.

---------

Co-authored-by: L. Bao
@baoliay2008
Copy link
Owner

Thanks for your contribution!

@baoliay2008 baoliay2008 added the enhancement New feature or request label May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants