Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add current job ID and current cluster name to banyanconfig.toml #63

Open
3 tasks
calebwin opened this issue Oct 19, 2021 · 2 comments
Open
3 tasks

Add current job ID and current cluster name to banyanconfig.toml #63

calebwin opened this issue Oct 19, 2021 · 2 comments
Labels
banyan-jl Concerning Banyan.jl enhancement New feature or request

Comments

@calebwin
Copy link
Contributor

calebwin commented Oct 19, 2021

Currently we have a set of configuration parameters which are stored in banyanconfig.toml, environment variables, or parameters to the configure function.

  • Make configure also store and maintain cluster name and job ID
  • Migrate all functions from using cluster_name/name as a parameter to simply calling configure
  • Migrate all functions from using current_job_id to simply calling configure

This will improve the consistency across the API and make it super easy for a user to understand and specify what Banyan account, AWS account, cluster, and job are being used at any point.

@calebwin calebwin added banyan-jl Concerning Banyan.jl enhancement New feature or request labels Oct 19, 2021
@cailinw
Copy link
Contributor

cailinw commented Oct 19, 2021

Won't this make it hard to run multiple jobs at the same time? e.g., running multiple jobs from different processes

@calebwin
Copy link
Contributor Author

Good point, I hadn't thought about that. I think we should still do this but the only change should be that we should cache all configuration parameters in memory. So for each configuration parameter, we should have a global variable to cache that parameters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
banyan-jl Concerning Banyan.jl enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants