Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements for cluster creation and management #54

Merged
merged 15 commits into from Oct 19, 2021
Merged

Improvements for cluster creation and management #54

merged 15 commits into from Oct 19, 2021

Conversation

cailinw
Copy link
Contributor

@cailinw cailinw commented Oct 14, 2021

No description provided.

@cailinw cailinw linked an issue Oct 14, 2021 that may be closed by this pull request
Make SSH key pair optional #23
Open
@cailinw cailinw mentioned this pull request Oct 19, 2021
Closed
@cailinw cailinw marked this pull request as ready for review October 19, 2021 07:21
@cailinw cailinw requested a review from calebwin October 19, 2021 07:21
@cailinw cailinw changed the title [WIP] Improvements for cluster creation and management Improvements for cluster creation and management Oct 19, 2021
calebwin
calebwin requested changes Oct 19, 2021
View reviewed changes
Copy link
Contributor

@calebwin calebwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. Is update_cluster tested? Make sure that the tests are comprehensively getting different configurations.

Banyan/src/clusters.jl Outdated Show resolved Hide resolved
Banyan/src/clusters.jl Show resolved Hide resolved
Banyan/src/clusters.jl Outdated Show resolved Hide resolved
Banyan/src/clusters.jl Outdated Show resolved Hide resolved
@cailinw
Copy link
Contributor Author

cailinw commented Oct 19, 2021

Yes, update_cluster is tested

@calebwin calebwin merged commit ec6dda4 into v0.1.3 Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calebwin calebwin calebwin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make SSH key pair optional
2 participants
@cailinw @calebwin